trixi-framework / trixi-framework/TrixiParticles.jl
Shall we move long hard-coded coordinate arrays in the test files to separate files?
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 83
- Forks
- 24
- Avg merge
- 8d 18h
- Merged PRs (30d)
- 3
Description
Hm, we also hard code the coordinates for the RectangularTank tests. Is it worth loading the coordinates from a separate file? It took me a while to generate this, and I need to generate this again for a csv file. Can we leave it as is and if it gets complicated we can still add a separate csv file. @efaulhaber what's your opinion on this?
On the other hand, it's a good point to put coordinates for setup tests in a separate csv file...
Originally posted by @LasNikas in https://github.com/trixi-framework/TrixiParticles.jl/pull/437#discussion_r1547822656
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the RectangularTank tests and other setup tests containing hard-coded coordinate arrays, then check whether the repository already has a CSV fixture convention. Define when coordinate data should remain inline versus move to separate files, and confirm the tests still use the same coordinates and pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100