trixi-framework / trixi-framework/TrixiParticles.jl

Do we need `current_coordinates` in the solid container?

Open
#143 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
83
Forks
24
Avg merge
8d 18h
Merged PRs (30d)
3

Description

We added this field for some reason instead of using u directly, but we can't remember why.
Maybe we can get rid of that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the Julia sources for the solid container, current_coordinates, and u, then trace every reference to determine why both fields exist. The issue names no files or tests, so first identify the relevant container definition and its callers. Done means establishing whether current_coordinates is redundant and documenting or implementing the agreed cleanup safely.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.