trixi-framework / trixi-framework/TrixiParticles.jl
Open boundaries don't work if `UpdateCallback` is not the last callback in the list
Open
Nobody has claimed this yet.
bug
- Dominant language
- Julia
- Stars
- 83
- Forks
- 24
- Avg merge
- 8d 18h
- Merged PRs (30d)
- 3
Description
For some reason, we are getting 1e16 coordinates (which are used by inactive particles) into the neighborhood search update (which is only done for active particles):
┌ Info:
│ point_coords =
│ 2-element SVector{2, Float64} with indices SOneTo(2):
│ 1.0e16
└ 1.0e16
┌ Info:
└ point in eachindex_y = true
ERROR: LoadError: particle coordinates are NaN or outside the domain bounds of the cell list
cell (3333333333333333505, 3333333333333333505) is out of bounds for cell grid of size [2:72, 2:37]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported open-boundary case and trace the callback list into the neighborhood search update, focusing on how inactive-particle coordinates reach that update when UpdateCallback is not last. Done means the reported out-of-bounds cell-list error no longer occurs and open boundaries work regardless of callback ordering; the issue names no files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100