trixi-framework / trixi-framework/Trixi.jl

Open questions/known issues with current implementation of direct-hybrid method for aeroacoustics

Open
#867 2 comments 0 reactions 0 assignees View on GitHub
discussion refactoring
Dominant language
Julia
Stars
731
Forks
166
Avg merge
2d 18h
Merged PRs (30d)
25

Description

This whole process seems to be overly convoluted to me. It's a good prototype that works, so I wouldn't change it now, but it seems to me like we are abusing a lot of the OrdinaryDiffEq machinery here. We should somehow find another way to make this work in a cleaner fashion.

If not already done, can you maybe start an issue with open questions and known issues with this implementation, such that we can collect them in one place? First item from my side:
* Find a cleaner way to implement the coupled Euler-Acoustics evolution than manually using OrdinaryDiffEq internals

_Originally posted by @sloede in https://github.com/trixi-framework/Trixi.jl/pull/712#discussion_r669669399_

List of open questions and known issues:

* Find a cleaner way to implement the coupled Euler-Acoustics evolution than manually using OrdinaryDiffEq internals
* `.h5` files generated by `AveragingCallback` are currently not compatible with Trixi2Vtk (discussed [here](https://github.com/trixi-framework/Trixi.jl/pull/712#discussion_r702560088))

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the direct-hybrid implementation and its use of OrdinaryDiffEq internals, then read the linked pull-request discussions for context. Investigate the two listed concerns: a cleaner coupled Euler-Acoustics evolution and the incompatibility between AveragingCallback-generated .h5 files and Trixi2Vtk. Done means the open questions and known issues have been resolved with an agreed cleaner implementation and compatible output.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
hpc
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.