trixi-framework / trixi-framework/Trixi.jl

Check whether the mesh is periodic when non-periodic BCs are used

Open
#752 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Julia
Stars
731
Forks
166
Avg merge
2d 18h
Merged PRs (30d)
25

Description

Discovered by @gregorgassner: We can, say, pass non-periodic `boundary_conditions` to the `SemidiscretizationHyperbolic` while the `TreeMesh` is still periodic by default. It would be nice to have some check whether that's the case and warn the user appropriately (or abort). The other way round may be even more problematic...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.