trixi-framework / trixi-framework/Trixi.jl
Use `withenv` instead of manual setting and re-setting ENV-fix for GR
Open
- Dominant language
- Julia
- Stars
- 731
- Forks
- 167
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 25
Description
See https://github.com/trixi-framework/Trixi.jl/blob/5b89962a78bc80de4bbeb8cb1cf2fe7f51aa4338/test/test_examples_2d_advection.jl#L56-L62
It would be cleaner to use `withenv`, maybe even at a higher level
Contributor guide
Research direction
Start in test/test_examples_2d_advection.jl at lines 56-62 and inspect how ENV is manually set and restored for GR. Replace that pattern with withenv, considering whether the environment handling belongs at a higher level. Run the relevant test file and confirm the GR-related examples still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100