trixi-framework / trixi-framework/Trixi.jl

Check `eos_newton_tol` for non-ideal EOS and different floating-point types, e.g., `Float32`.

Open
#3,123 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Julia
Stars
731
Forks
167
Avg merge
2d 18h
Merged PRs (30d)
25

Description

Right now, the default values of `eos_newton_tol(eos)` are typically set for `Float64`, e.g., `= 1e-8`. We should check which values make sense for other floating-point types such as `Float32`. See https://github.com/trixi-framework/Trixi.jl/pull/3079#discussion_r3513009300

Contributor guide

Open the contributing guide

Research direction

Start by locating the eos_newton_tol(eos) definitions and read the linked discussion in PR #3079. Compare the current defaults for non-ideal EOS implementations across floating-point types such as Float64 and Float32. Done means the appropriate tolerances are determined for the supported types and the relevant behavior is checked.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.