trixi-framework / trixi-framework/Trixi.jl

Non-deterministic CI results for `VolumeIntegralAdaptive` with `VolumeIntegralSubcellLimiting`

Open
#3,060 0 comments 0 reactions 0 assignees View on GitHub
testing
Dominant language
Julia
Stars
731
Forks
166
Avg merge
2d 18h
Merged PRs (30d)
25

Description

Somehow, we have failing test for `elixir_euler_sedov_adaptive_sc_subcell.jl` from time to time.
See for instance the [runs of this PR](https://github.com/trixi-framework/Trixi.jl/actions/runs/26823926280/job/79145797799) where the first run failed but the second passed.
The errors are about `1e-3` to `1e-4`.

We already noticed random failing test in #2924 where `VolumeIntegralAdaptive` was extended to `VolumeIntegralSubcellLimiting`. #3009 couldn't fix it. Next try in #3056.

Hot fix (increasing test tolerance) in #3061 .

Possible reason: Subcell limiting is known to be very sensitive to small changes. So, small differences can accumulate to errors of `1e-3`. Additionally, `VolumeIntegralAdaptive` has a hard switch to decide whether to use the default of the stabilized volume integral. That is known. Are there other reasons? Bugs?
Do we have the same problem with different julia versions than 1.10?

Contributor guide

Open the contributing guide

Research direction

Start by repeatedly running elixir_euler_sedov_adaptive_sc_subcell.jl and recording the failing values. Then inspect VolumeIntegralAdaptive and VolumeIntegralSubcellLimiting, review the attempts in #2924, #3009, and #3056, and compare behavior across Julia versions. Done means the source of the nondeterminism is identified and a reliable regression test or fix is established.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.