trixi-framework / trixi-framework/Trixi.jl

Remove `P4estMeshCubedSphere` from Trixi.jl, such that it only lives in TrixiAtmo.jl

Open
#3,044 2 comments 1 reaction 0 assignees View on GitHub
breaking
Dominant language
Julia
Stars
731
Forks
166
Avg merge
2d 18h
Merged PRs (30d)
25

Description

`P4estMeshCubedSphere` seems to be used by [TrixiAtmo.jl](https://github.com/trixi-framework/TrixiAtmo.jl) only. Moreover, it is being extended and modified within the [TrixiAtmo.jl](https://github.com/trixi-framework/TrixiAtmo.jl) repository (see https://github.com/trixi-framework/TrixiAtmo.jl/pull/187 and https://github.com/trixi-framework/TrixiAtmo.jl/pull/195). For that reason, I propose to completely move it to the [TrixiAtmo.jl](https://github.com/trixi-framework/TrixiAtmo.jl) repo.

Contributor guide

Open the contributing guide

Research direction

Start by locating the definition and all uses of P4estMeshCubedSphere in Trixi.jl, then review TrixiAtmo.jl pull requests 187 and 195 for the receiving implementation. Done means the mesh no longer lives in Trixi.jl and TrixiAtmo.jl retains the functionality without remaining references requiring the old location.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
hpc
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.