trixi-framework / trixi-framework/Trixi.jl

Exchange `DGMulti` dispatch types for new supertypes

Open
#2,985 0 comments 1 reaction 0 assignees View on GitHub
refactoring upstream
Dominant language
Julia
Stars
731
Forks
166
Avg merge
2d 18h
Merged PRs (30d)
25

Description

The idea is to replace e.g.

https://github.com/trixi-framework/Trixi.jl/blob/9a19e155e5d50c1c9811f15e00f1bc49675fed6f/src/solvers/dgmulti/flux_differencing.jl#L254

with

```julia
@inline function has_sparse_operators(::AbstractTensorProductElement,
```

This was made possible by https://github.com/jlchan/NodesAndModes.jl/pull/17

Contributor guide

Open the contributing guide

Research direction

Start at src/solvers/dgmulti/flux_differencing.jl around line 254 and compare the existing DGMulti dispatch type with AbstractTensorProductElement. Read NodesAndModes.jl pull request 17 to understand the new supertypes, then update the relevant dispatches and verify that the affected solver behavior remains covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.