trixi-framework / trixi-framework/Trixi.jl

Interface to avoid exposure of solver internals in usage of `get_node_variable`

Open
#2,902 5 comments 2 reactions 0 assignees View on GitHub
breaking refactoring
Dominant language
Julia
Stars
731
Forks
166
Avg merge
2d 18h
Merged PRs (30d)
25

Description

Using `get_node_variable` to save extra node variables in the `SaveSolutionCallback` currently requires implementing an iteration over nodal values and/or directly accessing the containers:

- https://github.com/trixi-framework/Trixi.jl/blob/main/examples/p4est_2d_dgsem/elixir_navierstokes_vortex_street.jl
- https://github.com/trixi-framework/Trixi.jl/blob/main/examples/t8code_3d_dgsem/elixir_euler_ec.jl
- https://github.com/trixi-framework/Trixi.jl/blob/main/examples/tree_2d_dgsem/elixir_euler_blast_wave_amr.jl
- https://github.com/trixi-framework/Trixi.jl/blob/main/examples/tree_2d_dgsem/elixir_euler_vortex_amr.jl

[As suggested here](https://github.com/trixi-framework/Trixi.jl/pull/2874#discussion_r3007728760) by @DanielDoehring, this could be streamlined so that only the pointwise transformation of solution variables (and possibly gradients, if available in the parabolic cache) needs to be implemented. Possibly related: #2854.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.