trixi-framework / trixi-framework/Trixi.jl
Floating-point discrepancy between Ubuntu and MacOS tests for `DGMulti` prism solver
- Dominant language
- Julia
- Stars
- 731
- Forks
- 167
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 25
Description
In #2259, it was noted that for `Wedge` elements with a scalar polynomial degree (i.e. using the elixir https://github.com/trixi-framework/Trixi.jl/blob/dgmulti-mesh-io-support/examples/dgmulti_3d/elixir_advection_tensor_wedge.jl with `polydeg = 3` instead of the default `polydeg = (3, 4)`), Ubuntu and MacOS give `linf` error values which differ a bit more than usually observed for double-precision arithmetic. Relaxing `atol` to 1e-10 gets the tests to pass, but it is still unclear what the cause of such discrepancies is; decreasing the time step helps only marginally (even with a drastically smaller CFL and/or switching to a fixed step size, the tests do not pass under the default tolerances for `linf`).
Contributor guide
Research direction
Start with examples/dgmulti_3d/elixir_advection_tensor_wedge.jl, changing polydeg to 3 as described, and run the Ubuntu and macOS tests with their default tolerances. Compare the linf errors while checking the DGMulti prism solver and time-step settings; done means the discrepancy's cause is identified and the tests pass consistently or the tolerance change is justified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100