trixi-framework / trixi-framework/Trixi.jl

Replace `@error ...` by `error(...)` (or something else)?

Open
#2,350 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
731
Forks
167
Avg merge
2d 18h
Merged PRs (30d)
25

Description

It seems like `@error ...` does not stop execution anymore (it used to, didn't it 🤔). We still use it in ~6 places - should we change this to `error(...)`? Or is there even are more canonical way nowadays?

Contributor guide

Open the contributing guide

Research direction

Search the repository for the roughly six uses of `@error` and inspect how execution behaves after each one. Check Julia's current error-handling guidance and existing project conventions before choosing an approach. Done means the intended behavior is consistent at every use site and covered by relevant tests, if present.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.