trixi-framework / trixi-framework/Trixi.jl

Formatting is ugly sometimes

Open
#1,758 5 comments 0 reactions 0 assignees View on GitHub
upstream
Dominant language
Julia
Stars
731
Forks
167
Avg merge
2d 18h
Merged PRs (30d)
25

Description

This is ugly:
https://github.com/trixi-framework/Trixi.jl/blob/d7e1f746462e806a317f005d4745c9c7db739d95/src/equations/equations.jl#L418-L424

This as well:
https://github.com/trixi-framework/Trixi.jl/blob/d7e1f746462e806a317f005d4745c9c7db739d95/src/equations/compressible_navier_stokes_2d.jl#L133-L140

This could probably be fixed in JuliaFormatter.

Contributor guide

Open the contributing guide

Research direction

Inspect the cited ranges in src/equations/equations.jl and src/equations/compressible_navier_stokes_2d.jl, then check whether JuliaFormatter controls their formatting. Compare the affected code with JuliaFormatter's output; done means both cited sections are formatted cleanly without changing their behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.