trixi-framework / trixi-framework/Trixi.jl

Finish upwind SBP implementation

Open
#1,284 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Julia
Stars
731
Forks
166
Avg merge
2d 18h
Merged PRs (30d)
25

Description

The first experimental version is implemented in https://github.com/trixi-framework/Trixi.jl/pull/1275.

### TODO

- [x] https://github.com/trixi-framework/Trixi.jl/pull/1570
- [ ] Remove all `!!! warning "Experimental implementation (upwind SBP)"`
- [ ] Clean-up the `SaveSolutionCallback` such that it works smoothly with FDSBP methods. See comment
```julia
# TODO: This is hack to enable the FDSBP solver to use the
# `SaveSolutionCallback`.
```
- [ ] Enhance and clean-up visualization pipeline; for VTK style viz see [here](https://github.com/trixi-framework/Trixi2Vtk.jl/pull/57). Direct visualization in a REPL session requires modification to recipes for Plots or Makie.
- [ ] Mention postprocessing in the tutorial once the corresponding Trixi2Vtk.jl updates are finished (https://github.com/trixi-framework/Trixi2Vtk.jl/pull/57)
- Remember to pass `reinterpolate = false, data_is_uniform = true` to `trixi2vtk`!
- Store the nodes additionally so that passing `data_is_uniform` is not required anymore?
- [ ] From https://github.com/trixi-framework/Trixi.jl/pull/1275#issuecomment-1335050004: "The only thing you might want to consider is adding the FDSBP solver to the table in https://trixi-framework.github.io/Trixi.jl/stable/overview/#Semidiscretizations, maybe with a footnote that it still experimental."
- [ ] De-aliased `VolumeIntegralStrongForm`, see https://github.com/trixi-framework/Trixi.jl/pull/1295#discussion_r1047971304 and https://github.com/trixi-framework/Trixi.jl/pull/1857
- [ ] Remove restriction `xmin = -1, xmax = 1` for curved meshes (see https://github.com/trixi-framework/Trixi.jl/pull/1857#discussion_r1512265923)

See also https://github.com/trixi-framework/Trixi.jl/issues/607

Contributor guide

Open the contributing guide

Research direction

Start by reading the experimental implementation in PR 1275, the completed PR 1570, and the related issue 607. Review each unchecked TODO, including SaveSolutionCallback, visualization, tutorial documentation, the FDSBP table entry, and de-aliased VolumeIntegralStrongForm work. Done means the listed cleanup, documentation, visualization, and solver follow-ups are completed and the experimental warnings and mesh restriction are addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend, data-visualization, documentation
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.