trixi-framework / trixi-framework/PointNeighbors.jl
Add support for inactive particles
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 27
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
The open boundaries in https://github.com/trixi-framework/TrixiParticles.jl/pull/442 require inactive and active particles.
So far, we avoid adding inactive particles to the neighbor lists by setting very large coordinates.
This could be circumvented by passing active_coordinates instead of current_coordinates.
The problem is, that we then have to remove inactive particles from the neighbor lists in every update_nhs!.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the neighborhood-list update_nhs! routines and the handling of current_coordinates versus active_coordinates. Trace how inactive particles enter neighbor lists, then define support for active and inactive particles without relying on artificially large coordinates; done means each update produces correct neighbor lists for the two states.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100