trixi-framework / trixi-framework/PointNeighbors.jl
Bounds check for full cell list is ignored
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 27
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Description
average cell occupancy (~173) exceeds FullGridCellList's
default max_points_per_cell = 100. The bounds check that would normally catch this
("cell list is full. Use a larger max_points_per_cell.") is skipped in the parallel
update path for performance, so points beyond the limit were silently dropped
instead of raising an error.
Reported by @lmiq in https://github.com/trixi-framework/PointNeighbors.jl/pull/171.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the parallel update path for FullGridCellList and compare its handling of full cells with the normal path. Reproduce a cell occupancy above the default max_points_per_cell of 100; done means the parallel path raises "cell list is full. Use a larger max_points_per_cell." instead of silently dropping points.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100