trinodb / trinodb/trino-python-client
Sqlalchemy transactions with Repeatable_read
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 439
- Forks
- 206
- PR merge metrics
- No merged PRs in 30d
Description
Expected behavior
dding a isolation level in the SA Session causes a failure when using any of the levels with underscores.
Trino client is removing the underscore, but then SA requires the underscore in downstream methods for a enum lookup.
Looking at the tests, it seems like it was not tested against the isolation levels with underscores.
Thanks.
Actual behavior
Fails
Steps To Reproduce
Use isolation level REPEATABLE_READ with SA
Log output
No response
Operating System
Windoss
Trino Python client version
Latest
Trino Server version
429
Python version
3.9
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the existing isolation-level tests and the Trino Python client's handling of SQLAlchemy session transaction settings. Reproduce the failure with REPEATABLE_READ and compare it with levels that do not contain underscores. Done means underscore-containing isolation levels work through the SQLAlchemy integration and are covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sqlalchemy
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100