trinodb / trinodb/trino-python-client
Fix handling of ambiguous datetime instances
Open
@hovaesco is already working on this.
Since Jul 10, 2024.
- Dominant language
- Python
- Stars
- 439
- Forks
- 206
- PR merge metrics
- No merged PRs in 30d
Description
Seems that the ambiguous date-time handling (TimestampWithTimeZone.normalize) hasn't been working since the beginning.
This code became "broken" (ie. calling non-existent method) in https://github.com/trinodb/trino-python-client/commit/2b9ca0c2e59496e168907fec1df7a50f26976dce#diff-cf9b945b8cb541d38680c39caa2de6568793a6d53644d6f2659de6a77ff96127R1040
I checked both before and after that commit/PR and the code isn't called by any tests.
See https://github.com/trinodb/trino-python-client/pull/446#discussion_r1477857147_ for additional context.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.