trinodb / trinodb/trino-python-client
Feature request: SQLAlchemy async
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 439
- Forks
- 206
- PR merge metrics
- No merged PRs in 30d
Description
Describe the feature
It would be great to provide a SQLAlchemy async demo, thanks!
SQLAlchemy says it supports async since version 1.4
This repo readme says
trino.sqlalchemy is compatible with the latest 1.3.x and 1.4.x SQLAlchemy versions at the time of release of a particular version of the client.
https://docs.sqlalchemy.org/en/20/orm/extensions/asyncio.html
However, I cannot make them work.
I guess for SQLAlchemy, I need install
pip install sqlalchemy[asyncio]
This repo I need run
pip install trino[sqlalchemy]
Apparently, this does not exist 🥲
pip install trino[sqlalchemy[asyncio]]
I guess it may be blocked by this https://github.com/trinodb/trino-python-client/issues/3 (?)
Describe alternatives you've considered
Use https://github.com/mvanderlee/aiotrino instead. However, it would be great to support async officially including SQLAlchemy async. Thanks!
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the existing trino[sqlalchemy] installation path and the SQLAlchemy asyncio documentation linked in the issue. Review the README compatibility statement and determine the scope of official async SQLAlchemy support. Done should include a working async SQLAlchemy demonstration and documented installation instructions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sqlalchemy
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100