trinodb / trinodb/trino-python-client
Enable mypy checks for the modules
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 439
- Forks
- 206
- PR merge metrics
- No merged PRs in 30d
Description
This PR https://github.com/trinodb/trino-python-client/pull/208 introduced mypy checks for subset of modules trino.exceptions, trino.logging, and trino.transactions. Enable checks for the rest of modules, which are disabled here: https://github.com/trinodb/trino-python-client/blob/master/setup.cfg#L22
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the mypy configuration in setup.cfg around line 22 and compare the enabled modules with the remaining modules in the package. Run mypy after expanding the checks and resolve the reported issues across those modules; done means the remaining modules are checked successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100