trinodb / trinodb/trino-python-client
Increase test coverage for sqlalchemy 1.3 api
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 439
- Forks
- 206
- PR merge metrics
- No merged PRs in 30d
Description
Describe the feature
Currently in CI we test both latest 1.3 and 1.4 sqlalchemy versions, however most sqlalchemy tests are only compatible with sqlalchemy 1.4 api and disabled for sqlalchemy 1.3.
Investigate if the same tests can be adapted or if it is better to split up the tests per version.
Describe alternatives you've considered
No response
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the CI configuration and the SQLAlchemy tests that are disabled or incompatible with SQLAlchemy 1.3. Compare the 1.3 and 1.4 API requirements, then determine whether the tests can be adapted together or need version-specific splits. Done means the relevant coverage runs successfully against both supported SQLAlchemy versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sqlalchemy
- Domain
- backend, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100