trinodb / trinodb/trino-python-client
Support comment creation with sqlalchemy
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 439
- Forks
- 206
- PR merge metrics
- No merged PRs in 30d
Description
Describe the feature
sqlalchemy provides support for comments on Tables and Columns
See https://docs.sqlalchemy.org/en/14/core/metadata.html#sqlalchemy.schema.Table.params.comment
https://docs.sqlalchemy.org/en/14/core/metadata.html#sqlalchemy.schema.Column.params.comment
The Trino implementation currently does not support this.
Describe alternatives you've considered
No response
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with SQLAlchemy's linked Table.comment and Column.comment documentation, then trace the Trino client's SQLAlchemy metadata and DDL entry points. Confirm how table and column definitions are currently emitted and identify the relevant existing tests; the work is done when comments supplied through both SQLAlchemy APIs are created correctly in Trino.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sqlalchemy
- Domain
- database
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100