triniwiz / triniwiz/nativescript-plugins
[couchbase] missing implementation for MutableDocument setValue
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 87
- Forks
- 57
- Avg merge
- 1h 36m
- Merged PRs (30d)
- 4
Description
I found a issue with the setValue method on the MutableDocument.
In the packages/nativescript-couchbase/index.d.ts there is the method defined, but the implementation is missing on iOS and android.
It should have the following implementations:
packages/nativescript-couchbase/index.android.ts
setValue(key: string, value: ValueType): this {
const native = valueToObject(value);
if (native !== undefined) {
this.native.setValue(key, native);
}
return this;
}
packages/nativescript-couchbase/index.ios.ts
setValue(key: string, value: ValueType): this {
const native = valueToObject(value);
if (native !== undefined) {
this.native.setValueForKey(native, key);
}
return this;
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the MutableDocument declaration in packages/nativescript-couchbase/index.d.ts, then inspect the corresponding classes in packages/nativescript-couchbase/index.android.ts and packages/nativescript-couchbase/index.ios.ts. Confirm that both platform implementations convert the value, set it on the native document when defined, and return the MutableDocument for chaining.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 85/100