trilogy-data / trilogy-data/pytrilogy

Remove adventureworks stuff?

Open
#255 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
61
Forks
3
Avg merge
7h 18m
Merged PRs (30d)
43

Description

Think maybe it's good to remove the completely unused adventureworks stuff? If you want to keep it I would recommend moving to a newer image and a different dataset e.g. https://www.brentozar.com/archive/2023/01/how-to-install-sql-server-and-the-stack-overflow-database-on-a-mac/

I feel like either remove the sql server report or add integration testing in CI for postgres and sqlserver both.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the unused AdventureWorks assets and the SQL Server report, then inspect the existing CI configuration and integration tests. The issue leaves two outcomes open: remove the unused material, or add PostgreSQL and SQL Server coverage; completion means carrying out one agreed direction and verifying the resulting report or CI checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgres, python, sql
Domain
ci-cd, databases, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.