trifectatechfoundation / trifectatechfoundation/sudo-rs
Better handling of closed user tty
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 4.5k
- Forks
- 179
- Avg merge
- 16h 45m
- Merged PRs (30d)
- 4
Description
Basically it seems like if the user tty is closed, we will have to close the pty leader and then manually send SIGHUP to the foreground process group. See also https://github.com/sudo-project/sudo/commit/41978a56e042977923c1a55191b887218c536145, https://github.com/sudo-project/sudo/commit/a2d01a957d31e133c37d77ae149527f9483e4f19, https://github.com/sudo-project/sudo/commit/62e4d29f8ee42aa520a68eb0241a53c7a2afe243, https://github.com/sudo-project/sudo/commit/fb208d383af27a07abe9cb277a620ea34c73f5d7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the four sudo commits linked in the issue and locating the corresponding tty and pty handling in sudo-rs. Trace what happens when the user tty closes. Done means the pty leader is closed and SIGHUP is sent to the foreground process group as needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100