trentm / trentm/python-markdown2
Bind self._safe_protocols to extras
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.8k
- Forks
- 459
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 4
Description
In:
https://github.com/trentm/python-markdown2/blob/master/lib/markdown2.py#L1274
_safe_protocols = re.compile(r'(https?|ftp):', re.I)
I would recommend that this is not hard-coded but rather there is an extra for it.
Alternatively, I would recommend to allow additional URL schemes such as mailto and tel.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/markdown2.py line 1274, where _safe_protocols is defined, and inspect how extras are handled around the URL-safety logic. Clarify whether the finished change should configure the existing protocols or add schemes such as mailto and tel, then verify the selected behavior with the relevant test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100