trekhleb / trekhleb/javascript-algorithms

Maybe there are some redundent code in Doubly-Linked-List

Open
#655 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
197k
Forks
31k
PR merge metrics
No merged PRs in 30d

Description

    reverse() {
        let node = this.head,
            previous = null,
            next = null;

        while (node) {
            next = node.next;
            console.log(previous?.value);
            previous = node.previous;
            console.log(previous?.value);
            node.next = previous;            
            node.previous = next;

            previous = node;
            node = next;
        }
        this.tail = this.head;
        this.head = previous;
        return this;
    }

I think the code previous = node.previous; in while loop is redundent code. I try this code and the previous.vaule always get a same value.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Doubly-Linked-List reverse() implementation shown in the issue and trace the previous, node, and next assignments through the loop. Determine whether the questioned assignment changes the result or is redundant, then confirm that the reversal behavior remains correct after any change.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.