trekhleb / trekhleb/javascript-algorithms

replaceChild in BinaryTreeNode, the replacementNode's parent is incorrect

Open
#369 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
197k
Forks
31k
PR merge metrics
No merged PRs in 30d

Description

const leftNode = new BinaryTreeNode(1);
const rightNode = new BinaryTreeNode(3);
const rootNode = new BinaryTreeNode(2);
rootNode
  .setLeft(leftNode)
  .setRight(rightNode);
expect(rootNode.traverseInOrder()).toEqual([1, 2, 3]);

const replacementNode = new BinaryTreeNode(5);
rightNode.setRight(replacementNode);
expect(rootNode.traverseInOrder()).toEqual([1, 2, 3, 5]);

expect(rootNode.replaceChild(rootNode.right, rootNode.right.right)).toBe(true);

expect(rootNode.right.parent.value).toBe(2); // Expected: 2, but Received: 3

It's better to set replacementNode's parent to this.left/this.right in replaceChild method of BinaryTreeNode

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at BinaryTreeNode.replaceChild and reproduce the case with the left, right, and replacement nodes shown in the issue. Verify the parent value after replacement and add or update the relevant BinaryTreeNode test so the replacement node is attached to the correct parent.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.