treeverse / treeverse/dvc

cloud/fs concurrency for large files

Open
#9,893 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A: data-sync fs: gs p3-nice-to-have
Dominant language
Python
Stars
15.9k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

@shcheklein in that case our concurrency level will be jobs * jobs, which is generally going to be way too high in the default case. I also considered splitting jobs between the two (so batch_size=(min(1, jobs // 2)) and the same for max_concurrency) but that will make us perform a lot worse in the cases where you are pushing a large # of files that are smaller than the chunk size

I think it will be worth revisiting this to properly determine what level of concurrency we should be using at both the file and chunk level, but that is dependent on the number of files being transferred, the size of all of those files, and the chunk size for the given cloud. This is all work that we can do at some point, but in the short term I prioritized getting a fix for the worst case scenario for azure (pushing a single large file).

Also, any work that we do on this right now would only work for Azure, since right now adlfs is the only underlying fsspec implementation that actually does concurrent chunked/multipart upload/downloads . It would be better for us to contribute upstream to make the s3/gcs/etc implementations support the chunk/multipart concurrency first, before we get into trying to make DVC optimize balancing file and chunk level concurrency

Originally posted by @pmrowla in https://github.com/iterative/dvc-objects/issues/218#issuecomment-1672435786

Tasks
- [x] S3: https://github.com/fsspec/s3fs/pull/848
- [ ] GCS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by tracing the cloud/fs transfer path for GCS and compare it with the completed S3 work and the Azure concurrency discussion. Done means the unchecked GCS task is implemented and its large-file concurrency behavior is covered consistently with the issue's scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, google-cloud, python
Domain
backend, cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.