trailofbits / trailofbits/graphtage

Expects quoted attributes in HTML unnecessarily, preventing diffing

Open
#25 2 comments 0 reactions 1 assignee View on GitHub

@ESultanik is already working on this.

Since Sep 3, 2020.

bug enhancement good first issue
Dominant language
Python
Stars
2.5k
Forks
61
Avg merge
6h 45m
Merged PRs (30d)
45

Description

When trying to diff an HTML file, Graphtage throws an error when encountering e.g.:

<meta name=foo

because it expects quoted attributes like so:

<meta name="foo"

However, the first variant without quotes is perfectly valid HTML and should not prevent Graphtage from diffing the file.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.