traefik / traefik/faency

[Popover] improve content sizing

Open
#266 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
41
Forks
16
Avg merge
3d 1h
Merged PRs (30d)
3

Description

minHeight on the popover content seems a bad idea that we should remove at some point

Originally posted by @matthieuh in https://github.com/traefik/faency/pull/262#pullrequestreview-865915960

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Popover content implementation and find the minHeight usage; the issue does not name a file or test. Confirm the intended sizing behavior with maintainers, then remove the minHeight behavior and verify that the popover content sizes correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.