traPtitech / traPtitech/anke-to
sort paramの値がそのままmodelパッケージの関数に渡っている
Open
Nobody has claimed this yet.
refactoring
- Dominant language
- Go
- Stars
- 8
- Forks
- 4
- Avg merge
- 6d 14h
- Merged PRs (30d)
- 3
Description
sort paramの値がそのままmodelパッケージの関数に渡っていると、クエリパラメーターの見た目を変えたくなった時に
modelの処理をいじる必要が出てしまい良くない。
modelの関数はiotaを使った擬似enumの値を引数に取るようにして、クエリパラメーターからsort方法への変換はrouterでやるようにしたい。
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the sort query parameter from the router into the model package. Identify the model functions that currently accept the raw parameter and the router code that should translate it into an iota-based pseudo-enum. Done means the model API accepts enum values while query-parameter-to-sort conversion remains in the router; no file or test names are provided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100