traPtitech / traPtitech/Checkin

入出金一覧に商品情報・支払い参照を含める

Open
#20 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
0
Forks
0
Avg merge
3d 5h
Merged PRs (30d)
7

Description

背景

会計の入出金一覧では「何の支払いか(商品)」と「支払いの参照(Stripe ダッシュボードへの導線)」を出したいが、現状 invoices.list / checkout.sessions.list の出力(allowlist の View)はこれらを含まない。

やること

  • Invoice: lines(既定でインライン展開される)から、price / product の参照(ID)と各行の数量・金額を allowlist で組み立てて出力に加える。
  • Checkout Session: line_items は expand が必要。expand は漏洩経路として入力では禁止しているため、サーバー側で限定的に expand する可否・粒度を検討する。
  • 支払い参照(payment_intent 等)を各 View に ID のみで加える。

関連

  • 出力は自作 z.object の allowlist 方式(Stripe 型を露出しない)を維持する。

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the invoices.list and checkout.sessions.list implementations and their custom z.object allowlist Views. Check how Invoice lines and Checkout Session line_items are currently fetched, then determine a server-controlled expansion scope and add only the requested product, quantity, amount, and payment-reference IDs. Done means both views expose these fields without leaking Stripe types or allowing expansion through input.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend, payments
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.