tpope / tpope/vim-obsession

winheight cannot be smaller than winminheight

Open
#4 23 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Vim Script
Stars
1.9k
Forks
73
PR merge metrics
No merged PRs in 30d

Description

Nice plugin!

I have these settings in my .vimrc courtesy of Gary Bernhardt's Destroy All Software screencast series.

set winwidth=84
" We have to have a winheight bigger than we want to set winminheight. But if
" we set winheight to be huge before winminheight, the winminheight set will
" fail.
set winheight=5
set winminheight=5
set winheight=999

When I go to load up a saved session I receive the following error:

Screen Shot 2013-03-12 at 1 05 14 PM

I'm not sure what is setting winheight=1, but that isn't in my .vimrc. Is that something this plugin is setting? It doesn't seem like it matters much, the sessions load fine, but it's obviously an eye sore / slow to have it error out each time I load up a saved session.

Thanks for taking a look!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the error with the reported .vimrc settings and a saved session, then inspect how obsession writes and loads session files. Confirm which setting produces winheight=1 and verify that loading the session no longer reports the error while preserving the expected window settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
vim
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.