toshok / toshok/echojs

many ops don't call ToPrimitive

Open
#48 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug easy spec
Dominant language
JavaScript
Stars
431
Forks
20
PR merge metrics
No merged PRs in 30d

Description

the kangax test for Symbol.toPrimitive fails for ejs because a few of the ops don't call ToPrimitive.

Probably most importantly, we're missing an implementation of Abstract Relational Comparison.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the kangax Symbol.toPrimitive test and the referenced ES6 Abstract Relational Comparison specification section. Trace the operations involved in echojs and identify where ToPrimitive is skipped; done means the relevant operations follow the specified conversion behavior and the kangax test passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.