tortoise / tortoise/tortoise-orm
The as_query method in the queryset.py file has been removed
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5.6k
- Forks
- 516
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 9
Description
Describe the bug
The as_query() method of the AwaitableQuery class was removed in version 0.24.0, and I haven't found any alternative method to replace it. This method was extremely useful for converting a queryset to a QueryBuilder. I'm wondering if this removal was an intentional/planned change, or an accidental one.
Here are two historical changes to this method:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in queryset.py with the AwaitableQuery class and inspect the history around the removed as_query() method. Determine whether the method was intentionally removed and identify the current path for converting a queryset to a QueryBuilder. Done means the intended replacement or restoration is established and covered by the relevant queryset tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100