tortoise / tortoise/tortoise-orm
Database connection was not released causing a new request to be pending
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5.6k
- Forks
- 516
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 9
Description
Describe the bug
When some abnormality occurs in the database connection, the connection will not be released back to the connection pool normally, and new requests will not be able to get the connection. This is a fatal problem. Looking forward to it being resolved.
To Reproduce
It can be reproduced by disconnecting the connection in use. After the connection is disconnected, the program will report an error, resulting in the connection not being released normally. But the size of the connection pool is limited, so new connections will not be created. New requests will wait for connections.
Expected behavior
If the database connection encounters an unexpected situation during use, it is necessary to ensure that the connection is released back to the connection pool normally.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue described in the body: disconnect an in-use database connection and observe the resulting error and connection-pool behavior. Trace the request and connection-pool entry points involved in that failure path. Done means an unexpected database disconnect returns the connection appropriately so later requests are not left waiting indefinitely.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100