tornadoweb / tornadoweb/tornado
simple_httpclient connection pooling (feature)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 22.2k
- Forks
- 5.6k
- Avg merge
- 3h 42m
- Merged PRs (30d)
- 16
Description
I was considering using Tornado's httpclient to replace a pycurl implementation but saw that simple_httpclient does not do connection pooling. Perhaps it would make sense to implement in by pulling in from urllib3's connection pool.
https://github.com/shazow/urllib3/blob/master/test/test_connectionpool.py
Does this seem like the right approach, or would you rather tornado rolls its own idea of a connection pool?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Tornado's simple_httpclient implementation and the linked urllib3 test_connectionpool.py. The issue asks whether to reuse urllib3's connection pool or design Tornado's own, so the first step is clarifying that architectural choice; completion criteria are not defined in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, networking
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100