tornadoweb / tornadoweb/tornado
Refactor xheaders configuration
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 22.2k
- Forks
- 5.6k
- Avg merge
- 3h 42m
- Merged PRs (30d)
- 16
Description
Xheader usage should not just be on or off, but specify which headers are expected (so an outsider can't spoof the one your proxy doesn't touch). For advanced usage (i.e. multiple layers of proxies) it might be nice to allow selection of a different value from the X-Forwarded-For list.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Tornado's xheaders configuration and the code that consumes X-Forwarded-For. Read the existing tests or configuration documentation around proxy headers, then define tests for selecting expected headers and, if supported, a value from a forwarded-for list; done means the configuration behavior and spoofing protections are explicit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, security
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100