tornadoweb / tornadoweb/tornado
simple_httpclient: Improve error reporting on connect timeout
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 22.2k
- Forks
- 5.6k
- Avg merge
- 3h 42m
- Merged PRs (30d)
- 16
Description
SimpleAsyncHTTPClient's timeout errors are not very informative: we distinguish connect timeouts from other timeouts, but nothing else. It would be helpful to provide more detail, in particular to distinguish DNS resolution from connecting to the HTTP host (which are both part of the "connect" phase).
A motivating example is #3520 in which a slow DNS configuration in kubernetes was responsible for connect timeouts, but this fact was not apparent.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with SimpleAsyncHTTPClient's connect-timeout handling and review the motivating case in issue #3520, focusing on how DNS resolution and HTTP-host connection are currently grouped. Done means timeout errors provide enough detail to distinguish DNS resolution from connecting to the host.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100