tornadoweb / tornadoweb/tornado

httpclient_test: test_destructor_log is flaky on windows

Open
#3,326 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

httpclient
Dominant language
Python
Stars
22.2k
Forks
5.6k
Avg merge
3h 42m
Merged PRs (30d)
16

Description

Unclear why, but tripling the timeout in https://github.com/tornadoweb/tornado/pull/3312 didn't help.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with httpclient_test and the test_destructor_log test, then review the timeout change in PR #3312 and reproduce the behavior on Windows. Done means identifying the cause of the flakiness and making the test reliable.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.