tornadoweb / tornadoweb/tornado
Any particular reason why calls to _handle_request_exception(e) or on_finish() are not being awaited ?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 22.2k
- Forks
- 5.6k
- Avg merge
- 3h 42m
- Merged PRs (30d)
- 16
Description
Hi,
Any particular reason why methods calls to _handle_request_exception(e) or on_finish() are not being awaited ?
In my implementation I'm overwriting these methods, but I need async support on them. I was trying to use asyncio functionality to handle my async calls , but it doesn't work properly in my project.
It's much easier to make a sync call from an async method then to make an async call from a sync method.
Thanks
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in tornado/web.py at the linked code around line 1709 and trace the calls to _handle_request_exception(e) and on_finish(). Review their call sites and overrides to understand the synchronous API assumptions; completion would require a documented decision and compatible async behavior, with relevant coverage identified before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100