tornado/test/gen_test.py:test_multi_performance is non-reproducible

Open
#2,583 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Start by reading test_multi_performance in tornado/test/gen_test.py and inspect how its one-second timing assertion works. Determine whether a reproducible ratio can replace the timing check; otherwise remove the test, then run the relevant test file to confirm the suite no longer depends on machine speed.

Written by the indexing model from the issue text.

Description

other

The test_multi_performance in tornado/test/gen_test.py tests that some bit of code executes in 1 second. Not only is this timing arbitrary, but it is not reproducible. On slow or loaded systems, it may or may not pass.

If it is possible, testing some kind of ratio would be better, or just removing the test altogether.

Dominant language
Python
Stars
22.2k
Forks
5.6k
Avg merge
3h 42m
Merged PRs (30d)
16

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tornadoweb/tornado

All issues in tornadoweb/tornado

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.