tornadoweb / tornadoweb/tornado

StreamClosedError not raised when connecting to a TLS server when using incorrect certificates

Open
#2,533 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

iostream
Dominant language
Python
Stars
22.2k
Forks
5.6k
Avg merge
3h 42m
Merged PRs (30d)
16

Description

Under some conditions (Python built against openssl 1.1+). Tornado does not raise a StreamClosedError when encountering UNKNOWN_CA errors.

See https://github.com/dask/distributed/pull/2331 for a manifestation of this issue (and a mitigation)

When using correct certificates the behavior is as expected.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No repository file or test is named. Start by reproducing a TLS connection to a server with incorrect certificates under Python built against OpenSSL 1.1+, then trace the connection's error handling and compare it with the correct-certificate behavior. Done means UNKNOWN_CA reliably results in StreamClosedError, with coverage for the reported conditions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.