torchbox / torchbox/django-pattern-library

Impossible to override context in for a child template

Open
#8 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug django
Dominant language
Python
Stars
423
Forks
53
PR merge metrics
No merged PRs in 30d

Description

In GitLab by @m1kola on Dec 14, 2017, 11:38

If you have a some_page.html&some_page.yaml and include_me.html&include_me.html and some_page.html includes include_me.html.

some_page.yaml with something like:

context:
  page:
    pk: 1
    title: "my title"

and include_me.yaml with something like:

context:
  page:
    title: "Title from include"

Title from include will appear on both patterns. It's impossible to override single key in some_page.html

cc @bcdickinson

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how context is merged for some_page.html and include_me.html, using the corresponding some_page.yaml and include_me.yaml examples in the issue. Verify that the included template can override only title while preserving page.pk from the parent context, and add or update coverage for that behavior if the relevant tests are found.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.