torchbox / torchbox/django-pattern-library

Accessibility issue: Main landmark should not be contained in another landmark on /django-pattern-library/demo/render-pattern/patterns_jinja/pages/search/search.html

Open
#323 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

axe rule: landmark-main-is-top-level axe-scanning-issue best-practice
Dominant language
Python
Stars
423
Forks
53
PR merge metrics
No merged PRs in 30d

Description

[!NOTE]
This is a best-practice recommendation, not a definite WCAG failure.

What

An accessibility scan flagged an element on https://torchbox.github.io/django-pattern-library/demo/render-pattern/patterns_jinja/pages/search/search.html because main landmark should not be contained in another landmark. Learn more about why this was flagged by visiting https://dequeuniversity.com/rules/axe/4.11/landmark-main-is-top-level?application=playwright.

The following element needs attention:

  • <main> (selector: main > main)

To fix this, ensure the main landmark is at top level.

Specifically:

Fix any of the following:

  • The main landmark is contained in another landmark.

Acceptance Criteria

  • The specific violation reported in this issue is no longer reproducible.
  • The fix MUST meet the accessibility standards specified by the repository or organization (WCAG 2.2 if applicable).
  • A test SHOULD be added to ensure this specific violation does not regress.
  • This PR MUST NOT introduce any new accessibility issues or regressions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the rendered search page at the linked URL and trace the template that produces the main > main selector. Re-run the accessibility scan using the referenced axe rule, then confirm the nested main landmark is gone and add a regression test if the repository’s existing test structure supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, html, python
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.