torchbox / torchbox/django-pattern-library

Accessibility issue: Landmarks should have a unique role or role/label/title (i.e. accessible name) combination on /django-pattern-library/demo/render-pattern/patterns/pages/search/search.html

Open Beginner friendly
#306 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

axe rule: landmark-unique axe-scanning-issue best-practice
Dominant language
Python
Stars
423
Forks
53
PR merge metrics
No merged PRs in 30d

Description

[!NOTE]
This is a best-practice recommendation, not a definite WCAG failure.

What

An accessibility scan flagged an element on https://torchbox.github.io/django-pattern-library/demo/render-pattern/patterns/pages/search/search.html because landmarks should have a unique role or role/label/title (i.e. accessible name) combination. Learn more about why this was flagged by visiting https://dequeuniversity.com/rules/axe/4.11/landmark-unique?application=playwright.

The following element needs attention:

  • <main> (selector: body > main)

To fix this, ensure landmarks are unique.

Specifically:

Fix any of the following:

  • The landmark must have a unique aria-label, aria-labelledby, or title to make landmarks distinguishable

Acceptance Criteria

  • The specific violation reported in this issue is no longer reproducible.
  • The fix MUST meet the accessibility standards specified by the repository or organization (WCAG 2.2 if applicable).
  • A test SHOULD be added to ensure this specific violation does not regress.
  • This PR MUST NOT introduce any new accessibility issues or regressions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the rendered search page at /django-pattern-library/demo/render-pattern/patterns/pages/search/search.html and inspect the body > main landmark reported by the Playwright accessibility scan. Make the landmark distinguishable as required by the issue, then rerun the scan and add a regression test if the repository’s test setup supports it; done means the reported violation is no longer reproducible without introducing new accessibility issues.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, html, python
Domain
accessibility, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.