top-think / top-think/think-orm
建议join() $condition参数支持function写法
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 437
- Forks
- 188
- PR merge metrics
- No merged PRs in 30d
Description
->join('tableName', function($join) {
$join->on('u.id', 'b.user_id')
->where('u.count', '>', 1)
})
这么写在多个约束下更清晰
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the join() entry point and trace how its $condition argument is processed. Compare the requested closure form with the existing condition handling, then add coverage for the shown callback syntax and verify that the join constraints are applied as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- database
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100