top-think / top-think/think-orm

1.2.17挺好用,但有两处需要修复下

Open
#190 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
437
Forks
188
PR merge metrics
No merged PRs in 30d

Description

  1. db/Query.php文件559行{}需要换成[],兼容php7.4
  2. Model.php文件164行,$suffix获取方式建议$config['class_suffix']直接设置$suffix的值,方便兼容更多目录格式。

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading db/Query.php around line 559 and Model.php around line 164. Check the requested PHP 7.4 syntax compatibility and how config['class_suffix'] is used for different directory formats. Done means both compatibility changes are applied without breaking the ORM behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.